Comments for LeetNightshade

Comment on Creating and Optimizing a C++ Function – sin by leetnightshade

leetnightshade — Sat, 12 May 2012 20:38:23 +0000

Hey Chris, thanks a lot for the reply! Moving the negation is a good idea, can’t believe I didn’t think of it. Though I’m slightly confused, perhaps my brain is still fried from our crunch period, or not having touched this for a while: “you would also need to work out these pre-loop val2 dependencies”. I believe outside of the loop there aren’t any val2 dependencies, the vars you mention refer to ‘val’.

Comment on Creating and Optimizing a C++ Function – sin by Chris

Chris — Thu, 10 May 2012 06:08:04 +0000

Of course, you would also need to work out these pre-loop val2 dependencies for the change I posted:

T num = val;
T expDivFact = val;

-Chris

Comment on Creating and Optimizing a C++ Function – sin by Chris

Chris — Thu, 10 May 2012 05:59:43 +0000

One more thing you should do is pull the negation operator out of the loop:

const T val2 = val * val;
…
expDivFact = -expDivFact * val2 / (f * (f – 1));

becomes

const T val2 = -val * val;
…
expDivFact = expDivFact * val2 / (f * (f – 1));

For T=double, the compiler possibly does this for you during optimization. A custom numeric class is more likely to see some benefit.

-Chris

Comment on Now employed at Gameloft! by zae

zae — Wed, 09 Nov 2011 01:58:51 +0000

LUUUUUUUUUCK! You’ll be fine, sir, because you’ve got the skillz :3

Comment on C++ Vector3 class by leetnightshade

leetnightshade — Tue, 08 Nov 2011 21:05:25 +0000

Thank you for thanking me, as others haven’t done so! I’m glad to hear my post has been of use, and with that said I’m terribly sorry I haven’t posted the source files all nicely packaged to go. I will do so, thanks!

Comment on C++ Vector3 class by leetnightshade

leetnightshade — Tue, 08 Nov 2011 21:03:50 +0000

Thanks!! When I post the code into my WordPress text block it has issues with ‘< ' and '>‘ thinking I’m using inline HTML; if I post the code in visual mode it doesn’t actually preserve the formatting of the code, last time I tested it. So, I’m updating the include, which is ‘#include ‘. I’ve usually been good about catching these, so thanks for catching it and notifying me good sir.

Comment on C++ Vector3 class by leetnightshade

leetnightshade — Tue, 08 Nov 2011 21:01:15 +0000

Ah, thanks for catching that. The file includes math constants, which is named differently in my up-to-date Vector3 class. One of the constants used here that is in the ‘Constants.h’ file is ‘W_PI_2′. Um, I’ll update the constant with something more standard for you and the others out there. Thanks!

Comment on C++ Vector3 class by gokhan

gokhan — Sun, 06 Nov 2011 20:47:38 +0000

sorry for different posts but, I also realised that there is line saying

#include “../Constants.h”

what does this have inside in it? It is missing.

thanks

Comment on C++ Vector3 class by gokhan

gokhan — Sun, 06 Nov 2011 20:45:52 +0000

there is a problem at Vector3.cpp:
line 3 empty include
line 8 std::numeric_limits

Comment on C++ Vector3 class by gokhan

gokhan — Sun, 06 Nov 2011 20:35:02 +0000

Thank you for this great share!